osc/skins
1
1
Fork 0
Code Issues 5 Pull Requests Actions Packages Projects 1 Releases Wiki Activity

add a check if in a collection of skins if the skin.ini has the same name as another skin #7

New Issue
Closed
opened 2025-06-08 00:53:09 +02:00 by Arlind · 6 comments
Arlind commented 2025-06-08 00:53:09 +02:00
Owner
Copy Link

currently if a skin collection has skin.ini that are for example
Name: test

every test skin will be overwritten by the last skin that rendered with the name test

the readme would show the last test skin 5 times

maybe save skins in a subdirectory after an index number or similar (or folder name since that would be unique hopefully)

currently if a skin collection has skin.ini that are for example Name: test every test skin will be overwritten by the last skin that rendered with the name test the readme would show the last test skin 5 times maybe save skins in a subdirectory after an index number or similar (or folder name since that would be unique hopefully)
Arlind self-assigned this 2025-06-08 00:53:12 +02:00
Arlind commented 2025-06-08 23:13:49 +02:00
Author
Owner
Copy Link

check added, solution not yet

check added, solution not yet
Arlind added this to the Skinhub Project project 2025-06-11 11:00:14 +02:00
Arlind moved this to High Priority in Skinhub Project on 2025-06-11 11:03:05 +02:00
Arlind moved this to Backlog in Skinhub Project on 2025-06-11 11:04:32 +02:00
Arlind moved this to In Progress in Skinhub Project on 2025-06-11 11:08:44 +02:00
Arlind commented 2025-06-11 14:32:49 +02:00
Author
Owner
Copy Link

almost done, only file cleanup and maybe migration needed (will probably just rebuild the repos)

almost done, only file cleanup and maybe migration needed (will probably just rebuild the repos)
Arlind commented 2025-06-13 14:07:12 +02:00
Author
Owner
Copy Link

nvm everything is a little fucked, if a skin ini name starts with - my current action doesnt respect that for some reason

nvm everything is a little fucked, if a skin ini name starts with - my current action doesnt respect that for some reason
Arlind commented 2025-06-13 14:12:39 +02:00
Author
Owner
Copy Link

and while im at it I will have to fix the % thing, replacing it with _ is ugly and not what I want URL encoding is %25

and while im at it I will have to fix the % thing, replacing it with _ is ugly and not what I want URL encoding is %25
Arlind commented 2025-06-15 23:58:07 +02:00
Author
Owner
Copy Link

I should probably do this tomorrow, everything is currently broken lol

I should probably do this tomorrow, everything is currently broken lol
Arlind commented 2025-06-16 12:12:53 +02:00
Author
Owner
Copy Link

removed check, but problem fixed.

skins with the same skin.ini dont overwrite each other

removed check, but problem fixed. skins with the same skin.ini dont overwrite each other
Arlind moved this to Deployed in Skinhub Project on 2025-06-16 12:38:14 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project Skinhub Project
Assignees
Clear assignees
Arlind
No Assignees Arlind
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: osc/skins#7
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?